yihua commented on code in PR #18224: URL: https://github.com/apache/hudi/pull/18224#discussion_r3034044229
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KinesisSourceConfig.java: ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.config; + +import org.apache.hudi.common.config.ConfigClassProperty; +import org.apache.hudi.common.config.ConfigGroups; +import org.apache.hudi.common.config.ConfigProperty; +import org.apache.hudi.common.config.HoodieConfig; + +import javax.annotation.concurrent.Immutable; + +import static org.apache.hudi.common.util.ConfigUtils.DELTA_STREAMER_CONFIG_PREFIX; +import static org.apache.hudi.common.util.ConfigUtils.STREAMER_CONFIG_PREFIX; + +/** + * Kinesis Source Configs for Hudi Streamer. + */ +@Immutable +@ConfigClassProperty(name = "Kinesis Source Configs", + groupName = ConfigGroups.Names.HUDI_STREAMER, + subGroupName = ConfigGroups.SubGroupNames.DELTA_STREAMER_SOURCE, + description = "Configurations controlling the behavior of Kinesis source in Hudi Streamer.") +public class KinesisSourceConfig extends HoodieConfig { + + public static final String KINESIS_CHECKPOINT_TYPE_STRING = "string"; + + private static final String PREFIX = STREAMER_CONFIG_PREFIX + "source.kinesis."; + private static final String OLD_PREFIX = DELTA_STREAMER_CONFIG_PREFIX + "source.kinesis."; + + public static final ConfigProperty<String> KINESIS_STREAM_NAME = ConfigProperty + .key(PREFIX + "stream.name") + .noDefaultValue() + .withAlternatives(OLD_PREFIX + "stream.name") + .withDocumentation("Kinesis Data Streams stream name."); Review Comment: Looks like this is missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
