nsivabalan commented on code in PR #17928:
URL: https://github.com/apache/hudi/pull/17928#discussion_r3024342596
##########
hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java:
##########
@@ -179,7 +179,31 @@ protected boolean
needUpdatingPersistedRecord(IndexedRecord currentValue,
if (incomingRecord.isEmpty() &&
OrderingValues.isDefault(incomingOrderingVal)) {
return true;
}
- return persistedOrderingVal == null ||
persistedOrderingVal.compareTo(incomingOrderingVal) <= 0;
+ boolean updateOnSameOrderingField =
Boolean.parseBoolean(properties.getProperty(
Review Comment:
hey @suryaprasanna :
Danny has a point.
can we not make any changes to `DefaultHoodieRecordPayload`.
Its ok to have more overrides in `ReverseOrderHoodieRecordPayload`, but lets
not touch `DefaultHoodieRecordPayload`.
Do you folks need the ordering related fix even for
`DefaultHoodieRecordPayload` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
