cshuo commented on code in PR #18282:
URL: https://github.com/apache/hudi/pull/18282#discussion_r2992732271
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -555,10 +560,12 @@ private void recommitInstant(HoodieTimeline
completedTimeline, long checkpointId
private void handleBootstrapEvent(WriteMetadataEvent event) {
if (event.getInstantTime().equals(WriteMetadataEvent.BOOTSTRAP_INSTANT)) {
this.eventBuffers.cleanLegacyEvents(event);
+ this.eventBuffers.notifyWriterBootstrapEventReceived();
return;
}
EventBuffer eventBuffer =
this.eventBuffers.getOrCreateBootstrapBuffer(event);
eventBuffer.addBootstrapEvent(event);
+ this.eventBuffers.notifyWriterBootstrapEventReceived();
Review Comment:
The commit guard for blocking RLI bootstrap is already optional inside
`eventBuffers`, maybe we can rename the method as
`notifyWriterBootstrapEventReceivedIfNecessary` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
