balaji-varadarajan-ai commented on code in PR #18098:
URL: https://github.com/apache/hudi/pull/18098#discussion_r2991494006
##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_3ExtendedSqlAstBuilder.scala:
##########
@@ -2686,13 +2689,24 @@ class HoodieSpark3_3ExtendedSqlAstBuilder(conf:
SQLConf, delegate: ParserInterfa
builder.putString("comment", _)
}
+ val dataType = typedVisit[DataType](ctx.dataType)
+
+ addMetadataForType(ctx.dataType(), builder)
+
StructField(
name = colName.getText,
- dataType = typedVisit[DataType](ctx.dataType),
+ dataType = dataType,
nullable = NULL == null,
metadata = builder.build())
}
+ private def addMetadataForType(dataType:
HoodieSqlBaseParser.DataTypeContext, builder: MetadataBuilder): Unit = {
Review Comment:
nit - looks duplicated. may be move to common class ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
