prashantwason commented on PR #18089: URL: https://github.com/apache/hudi/pull/18089#issuecomment-4084621141
@nsivabalan All review comments addressed (commit 17d05c7): 1. **Inflight rollback during conflict resolution** — Clarified: `filterPendingRollbackTimeline()` includes both REQUESTED and INFLIGHT rollbacks. For both states, the rollback plan is read from the requested instant to extract the target commit time. So even if the rollback is inflight, the ingestion writer's conflict resolution will detect it and throw `HoodieWriteConflictException`. 2. **Rollback conflict for table services** — Removed `getCandidateInstantsForRollbackConflict` from the table services path. Table service rollbacks are done by table service jobs/writers only, not by ingestion threads, so this check is only needed for ingestion commits. **CI note:** The Azure CI failure (`/usr/bin/docker failed with exit code 1`) was a Docker infrastructure issue, not a test failure — all 500 tests passed (0 Failures, 0 Errors). All GitHub Actions are green. Could you take another look when you get a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
