nsivabalan commented on code in PR #18223:
URL: https://github.com/apache/hudi/pull/18223#discussion_r2921932846


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -191,6 +191,37 @@ public class HoodieWriteConfig extends HoodieConfig {
           "**Note** This is being actively worked on. Please use "
               + "`hoodie.datasource.write.keygenerator.class` instead.");
 
+  public static final ConfigProperty<Boolean> COMPLEX_KEYGEN_NEW_ENCODING = 
ConfigProperty
+      .key("hoodie.write.complex.keygen.new.encoding")
+      .defaultValue(false)
+      .markAdvanced()
+      .sinceVersion("0.14.2")
+      .supportedVersions("0.14.2", "0.15.1", "1.0.3", "1.1.0")
+      .withDocumentation("This config only takes effect for writing table 
version 8 and below. "

Review Comment:
   the documentation might need fixes. 
   why do we call out `version 8 and below`. here we are looking to get this in 
for 0.14.2 right. 
   so lets just talk about 0.14.2 or table v6. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to