xushiyan commented on code in PR #18287:
URL: https://github.com/apache/hudi/pull/18287#discussion_r2898071104
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieSplitReaderFunction.java:
##########
@@ -56,12 +56,11 @@ public class HoodieSplitReaderFunction implements
SplitReaderFunction<RowData> {
private final HoodieSchema requiredSchema;
private final InternalSchemaManager internalSchemaManager;
private final Configuration configuration;
- private final org.apache.hadoop.conf.Configuration hadoopConf;
Review Comment:
we can keep this as a transient lazy init variable to avoid per read
creation?
```java
private transient org.apache.hadoop.conf.Configuration hadoopConf;
private org.apache.hadoop.conf.Configuration getHadoopConf() {
if (hadoopConf == null) {
hadoopConf = HadoopConfigurations.getHadoopConf(configuration);
}
return hadoopConf;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
