cshuo commented on code in PR #18287:
URL: https://github.com/apache/hudi/pull/18287#discussion_r2893556361
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/enumerator/AbstractHoodieSplitEnumerator.java:
##########
@@ -160,7 +160,6 @@ private void assignSplits() {
if (shouldWaitForMoreSplits()) {
// for continuous split provider callback
registerCallbackFromSplitProvider();
- break;
Review Comment:
Curious about the change here, `registerCallbackFromSplitProvider` will
register a callback which executes `assignSplits` again once there is split
available, so it seems make sense to break here?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieSplitReaderFunction.java:
##########
Review Comment:
`fileGroupReader` is not Serializable either, make it transient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
