nsivabalan commented on code in PR #17495:
URL: https://github.com/apache/hudi/pull/17495#discussion_r2651957231
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2347,6 +2347,10 @@ public long getHFileMaxFileSize() {
return getLong(HoodieStorageConfig.HFILE_MAX_FILE_SIZE);
}
+ public boolean hfileWriterToAllowDuplicates() {
Review Comment:
`allowDuplicatesWithHfileWrites()`
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -80,6 +80,11 @@ public class HoodieStorageConfig extends HoodieConfig {
.markAdvanced()
.withDocumentation("Target file size in bytes for HFile base files.");
+ public static final ConfigProperty<Boolean> HFILE_WRITER_TO_ALLOW_DUPLICATES
= ConfigProperty
Review Comment:
`hoodie.hfile.writes.allow.duplicates`
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java:
##########
@@ -72,4 +75,8 @@ public BloomFilter getBloomFilter() {
public String getKeyFieldName() {
return keyFieldName;
}
+
+ public boolean allowDuplicatesToBeInserted() {
Review Comment:
same here
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java:
##########
@@ -30,19 +30,22 @@ public class HoodieHFileConfig {
private final StorageConfiguration storageConf;
private final BloomFilter bloomFilter;
private final String keyFieldName;
+ private final boolean allowDuplicatesToBeInserted;
Review Comment:
lets try to align the variable from its root. so that we may not get
confused if this is a new one.
for eg,
lets stick to
`allowDuplicatesOnHfileWrites` consistently across all layers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
