yihua commented on code in PR #17637:
URL: https://github.com/apache/hudi/pull/17637#discussion_r2636226338
##########
hudi-spark-datasource/hudi-spark3.3.x/pom.xml:
##########
@@ -80,12 +80,6 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-1.8</arg>
Review Comment:
The POM of `hudi-spark3.5.x` and `hudi-spark4.0.x` modules have the same
args. Should that be removed too?
##########
hudi-spark-datasource/hudi-spark-common/pom.xml:
##########
@@ -37,26 +37,6 @@
<directory>src/main/resources</directory>
</resource>
</resources>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>${scala-maven-plugin.version}</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-1.8</arg>
Review Comment:
I see that `hudi-spark3-common`, `hudi-spark4-common` has similar plugin
configurations. Should those be removed too?
```
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
<executions>
<execution>
<id>scala-compile-first</id>
<phase>process-resources</phase>
<goals>
<goal>add-source</goal>
<goal>compile</goal>
</goals>
</execution>
<execution>
<id>scala-test-compile</id>
<phase>process-test-resources</phase>
<goals>
<goal>testCompile</goal>
</goals>
</execution>
</executions>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<executions>
<execution>
<phase>compile</phase>
<goals>
<goal>compile</goal>
</goals>
</execution>
</executions>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
