TheR1sing3un commented on code in PR #14366:
URL: https://github.com/apache/hudi/pull/14366#discussion_r2565654395
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -234,7 +234,7 @@ private List<HoodieInstant> loadInstants(boolean
loadInstantDetails) {
}
private List<HoodieInstant> loadInstants(String startTs, String endTs) {
- return loadInstants(new HoodieArchivedTimeline.TimeRangeFilter(startTs,
endTs), true);
+ return loadInstants(new
HoodieArchivedTimeline.OpenClosedTimeRangeFilter(startTs, endTs), true);
}
Review Comment:
Here, it's just a change in naming. Previously, `TimeRangeFilter` was
directly used to represent `( ]`
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ArchivedTimelineV2.java:
##########
@@ -131,7 +131,7 @@ public void loadCompactionDetailsInMemory(String
compactionInstantTime) {
public void loadCompactionDetailsInMemory(String startTs, String endTs) {
// load compactionPlan
- loadInstants(new HoodieArchivedTimeline.TimeRangeFilter(startTs, endTs),
HoodieArchivedTimeline.LoadMode.PLAN,
+ loadInstants(new HoodieArchivedTimeline.OpenClosedTimeRangeFilter(startTs,
endTs), HoodieArchivedTimeline.LoadMode.PLAN,
Review Comment:
As above comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
