the-other-tim-brown commented on code in PR #14265:
URL: https://github.com/apache/hudi/pull/14265#discussion_r2543282049
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaField.java:
##########
@@ -88,28 +88,13 @@ public static HoodieSchemaField fromAvroField(Schema.Field
avroField) {
* @return new HoodieSchemaField instance
*/
public static HoodieSchemaField of(String name, HoodieSchema schema, String
doc, Object defaultVal) {
- return of(name, schema, doc, defaultVal, HoodieFieldOrder.ASCENDING);
- }
-
- /**
- * Creates a new HoodieSchemaField with the specified properties, including
field order.
- *
- * @param name the name of the field
- * @param schema the schema of the field
- * @param doc the documentation string, can be null
- * @param defaultVal the default value, can be null
- * @param order the field order for sorting
- * @return new HoodieSchemaField instance
- */
- public static HoodieSchemaField of(String name, HoodieSchema schema, String
doc, Object defaultVal, HoodieFieldOrder order) {
ValidationUtils.checkArgument(name != null && !name.isEmpty(), "Field name
cannot be null or empty");
ValidationUtils.checkArgument(schema != null, "Field schema cannot be
null");
- ValidationUtils.checkArgument(order != null, "Field order cannot be null");
Schema avroSchema = schema.getAvroSchema();
ValidationUtils.checkState(avroSchema != null, "Schema's Avro schema
cannot be null");
- Schema.Field avroField = new Schema.Field(name, avroSchema, doc,
defaultVal, order.toAvroOrder());
+ Schema.Field avroField = new Schema.Field(name, avroSchema, doc,
defaultVal);
Review Comment:
@bvaradar please see the other comments, consensus is that the order is not
used so it will always be default value in Avro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
