the-other-tim-brown commented on code in PR #14265: URL: https://github.com/apache/hudi/pull/14265#discussion_r2540057296
########## hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieFieldOrder.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.schema; + +import org.apache.avro.Schema; + +import java.util.HashMap; +import java.util.Map; + +/** + * Enumeration of field sort orders supported by Hudi schema system. + * + * <p>This enum wraps Avro's Schema.Field.Order to provide a consistent interface + * for field ordering while maintaining binary compatibility with Avro.</p> + * + * @since 1.2.0 + */ +public enum HoodieFieldOrder { Review Comment: What does ordering do in Hudi? This shouldn't be hard to answer @bvaradar. I would appreciate straight forward answers instead of "I want some design pattern to be followed." These patterns are tools we can use but let's not blindly recreate functionality if it is not providing value to the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
