yihua commented on code in PR #14286:
URL: https://github.com/apache/hudi/pull/14286#discussion_r2536691963


##########
rfc/rfc-91/rfc-91-2.md:
##########
@@ -0,0 +1,75 @@
+
+# RFC-91-2: Storage LP conditional write retry handling

Review Comment:
   nit: directly amend the existing `rfc-91.md` instead of creating a new file?



##########
rfc/rfc-91/rfc-91-2.md:
##########
@@ -0,0 +1,75 @@
+
+# RFC-91-2: Storage LP conditional write retry handling
+
+Conditional writes with s3 which are retried due to transient issues are not 
idempotent, meaning that a successful PUT can go through but a retry can turn 
the response into a 412.

Review Comment:
   It would be good to clarify the particular scenario and sequence of 
(network) events that lead to unexpected 412 on a conditional PUT that 
successfully writes an object on S3.  Then we can decide how to work around the 
behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to