TheR1sing3un commented on code in PR #14198:
URL: https://github.com/apache/hudi/pull/14198#discussion_r2524516058
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/insert/TestInsertTable3.scala:
##########
@@ -755,7 +751,7 @@ class TestInsertTable3 extends HoodieSparkSqlTestBase{
)
val df = spark.read.format("hudi").load(tmp.getCanonicalPath)
assertEquals(3,
df.select(HoodieRecord.RECORD_KEY_METADATA_FIELD).count())
- assertResult(WriteOperationType.BULK_INSERT) {
+ assertResult(WriteOperationType.INSERT) {
Review Comment:
> Why is the write operation changed in this test?
For this test, what should be expected is an `INSERR`. Now, if the master
branch directly runs this test, it will also failed.
<img width="1005" height="597" alt="image"
src="https://github.com/user-attachments/assets/7b1af2b3-d18c-44dd-b260-56d2fba9830d";
/>
As for why CI checks does not failed, the reason is that CI runs an entire
test class. In other tests of this class, someone has set a write operation in
spark context conf.
<img width="915" height="161" alt="image"
src="https://github.com/user-attachments/assets/a75987ae-18d2-40e6-ba8c-877057f4b19a";
/>
So this writing type as `BULK_INSERT` is a kind of accidental operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
