wangxianghu commented on a change in pull request #2363:
URL: https://github.com/apache/hudi/pull/2363#discussion_r547755962
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -364,6 +365,9 @@ private[hudi] object HoodieSparkSqlWriter {
hiveSyncConfig.partitionValueExtractorClass =
parameters(HIVE_PARTITION_EXTRACTOR_CLASS_OPT_KEY)
hiveSyncConfig.useJdbc = parameters(HIVE_USE_JDBC_OPT_KEY).toBoolean
hiveSyncConfig.supportTimestamp =
parameters.get(HIVE_SUPPORT_TIMESTAMP).exists(r => r.toBoolean)
+ hiveSyncConfig.decodePartition =
+ parameters.getOrElse(URL_ENCODE_PARTITIONING_OPT_KEY,
+ KeyGeneratorOptions.DEFAULT_URL_ENCODE_PARTITIONING_OPT_VAL).toBoolean
Review comment:
It seems we already have a val named
`DEFAULT_URL_ENCODE_PARTITIONING_OPT_VAL` in `DataSourceOptions`, how about
using this one, avoid importing `KeyGeneratorOptions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
