danny0405 commented on code in PR #14013:
URL: https://github.com/apache/hudi/pull/14013#discussion_r2389729008
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/CompletionTimeQueryViewV2.java:
##########
@@ -102,7 +106,14 @@ public CompletionTimeQueryViewV2(HoodieTableMetaClient
metaClient) {
public CompletionTimeQueryViewV2(HoodieTableMetaClient metaClient, String
eagerLoadInstant) {
this.metaClient = metaClient;
this.instantTimeToCompletionTimeMap = new ConcurrentHashMap<>();
- this.cursorInstant = InstantComparison.minInstant(eagerLoadInstant,
metaClient.getActiveTimeline().firstInstant().map(HoodieInstant::requestedTime).orElse(""));
+ this.cursorInstant =
metaClient.getActiveTimeline().firstInstant().map(HoodieInstant::requestedTime).orElse("");
Review Comment:
Hi, the `eagerLoadInstant` is not configurable now, wondering how this patch
could improve the performance?
can we by default set the eagerLoadInstant as the first active instant and
not load loading the archived timeline instead? Not a fan of these flags
variables introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
