nsivabalan commented on code in PR #13950:
URL: https://github.com/apache/hudi/pull/13950#discussion_r2389515595
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:
##########
@@ -314,6 +314,21 @@ object HoodieWriterUtils {
&& currentPartitionFields != tableConfigPartitionFields) {
diffConfigs.append(s"PartitionPath:\t$currentPartitionFields\t$tableConfigPartitionFields\n")
}
+ // The value of `HoodieTableConfig.RECORD_MERGE_STRATEGY_ID` can be
NULL or non-NULL.
+ // The non-NULL value has been validated above in the regular code
path.
+ // Here we check the NULL case since if the value is NULL, the check
is skipped above.
+ // So here we check if the write config contains non-null merge
strategy id. If so, throw.
+ // Here are two exclusions:
+ // CASE 1: For < v9 tables, we skip check completely for backward
compatibility.
+ // CASE 2: For >= v9 tables, merge-into queries.
Review Comment:
whats this special handling for MIT queries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
