xushiyan commented on code in PR #432:
URL: https://github.com/apache/hudi-rs/pull/432#discussion_r2400737285
##########
crates/core/src/config/read.rs:
##########
@@ -142,20 +142,26 @@ mod tests {
),
]);
assert_eq!(
- InputPartitions.parse_value(&options).unwrap().to::<usize>(),
+ { let value: usize =
InputPartitions.parse_value(&options).unwrap().into(); value },
Review Comment:
try to avoid the pattern. use sth like this before the assert to keep code
clean. `actual` can be reused to save naming hassle. applies to all other
similar changes
```rust
let actual: usize =
InputPartitions.parse_value(&options).unwrap().into();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
