nsivabalan commented on code in PR #13987:
URL: https://github.com/apache/hudi/pull/13987#discussion_r2392837539
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/SparkDatasetMixin.scala:
##########
@@ -29,9 +29,17 @@ import scala.collection.JavaConverters._
trait SparkDatasetMixin {
def toDataset(spark: SparkSession, records: java.util.List[HoodieRecord[_]])
= {
- val avroRecords = records.asScala.map(
- _.getData
- .asInstanceOf[GenericRecord]
+ val record1 = records.get(0)
+ val isSerializableIndexedRecord =
record1.getData.isInstanceOf[SerializableIndexedRecord]
Review Comment:
this is just test right. I did benchmark.
as of now, this is only used while ingesting new data into hudi. and hence
does not have any delete handling. we don't need to account for deleted records
in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
