yihua commented on code in PR #13976:
URL: https://github.com/apache/hudi/pull/13976#discussion_r2395019742
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java:
##########
@@ -108,7 +109,9 @@ public boolean commit(String instantTime,
JavaRDD<WriteStatus> rawWriteStatuses,
final JavaRDD<WriteStatus> writeStatuses;
if
(WriteOperationType.streamingWritesToMetadataSupported((getOperationType())) &&
isStreamingWriteToMetadataEnabled(table)) {
// this code block is expected to create a new Metadata Writer, start a
new commit in metadata table and trigger streaming write to metadata table.
- writeStatuses =
HoodieJavaRDD.getJavaRDD(streamingMetadataWriteHandler.streamWriteToMetadataTable(table,
HoodieJavaRDD.of(rawWriteStatuses), instantTime));
+ boolean enforceCoalesceWithRepartition = getOperationType() ==
WriteOperationType.BULK_INSERT && config.getBulkInsertSortMode() ==
BulkInsertSortMode.NONE;
Review Comment:
nit: could this common condition be extracted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
