voonhous commented on code in PR #13927:
URL: https://github.com/apache/hudi/pull/13927#discussion_r2367183202
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -152,7 +172,7 @@ public ClosableIterator<IndexedRecord>
getFileRecordIterator(
} else {
HoodieFileFormat fileFormat = isMultiFormat && !isLogFile ?
HoodieFileFormat.fromFileExtension(filePath.getFileExtension()) :
baseFileFormat;
reader = (HoodieAvroFileReader) HoodieIOFactory.getIOFactory(storage)
-
.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO).getFileReader(new
HoodieConfig(),
+
.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO).getFileReader(hoodieConfig,
Review Comment:
Deprecated this configuration and removed usages for it.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -843,6 +843,15 @@ object HoodieBaseRelation extends SparkAdapterSupport {
val hoodieConfig = new HoodieConfig()
hoodieConfig.setValue(USE_NATIVE_HFILE_READER,
options.getOrElse(USE_NATIVE_HFILE_READER.key(),
USE_NATIVE_HFILE_READER.defaultValue().toString))
+
+ // Add HFile cache configurations from options
+ hoodieConfig.setValue(HFILE_BLOCK_CACHE_ENABLED,
+ options.getOrElse(HFILE_BLOCK_CACHE_ENABLED.key(),
HFILE_BLOCK_CACHE_ENABLED.defaultValue().toString))
+ hoodieConfig.setValue(HFILE_BLOCK_CACHE_SIZE,
+ options.getOrElse(HFILE_BLOCK_CACHE_SIZE.key(),
HFILE_BLOCK_CACHE_SIZE.defaultValue().toString))
+ hoodieConfig.setValue(HFILE_BLOCK_CACHE_TTL_MINUTES,
+ options.getOrElse(HFILE_BLOCK_CACHE_TTL_MINUTES.key(),
HFILE_BLOCK_CACHE_TTL_MINUTES.defaultValue().toString))
Review Comment:
Deprecated this configuration and removed usages for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
