linliu-code commented on code in PR #13897:
URL: https://github.com/apache/hudi/pull/13897#discussion_r2363971748
##########
hudi-io/src/main/java/org/apache/hudi/io/hfile/HFileBlock.java:
##########
@@ -323,9 +321,9 @@ protected long getStartOffsetInBuffForWrite() {
* Returns checksum bytes if checksum type is not NULL.
* Note that current HFileReaderImpl does not support non-NULL checksum.
*/
- private byte[] generateChecksumBytes(ChecksumType type) {
+ private byte[] generateChecksumBytes(ChecksumType type, int
numChecksumBytes) {
if (type == ChecksumType.NULL) {
- return EMPTY_BYTE_ARRAY;
+ return new byte[numChecksumBytes];
Review Comment:
Does it means hbase reader will not check the content of these bytes since
the Checksum type is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
