danny0405 commented on code in PR #13896:
URL: https://github.com/apache/hudi/pull/13896#discussion_r2357442844
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroRecordSizeEstimator.java:
##########
@@ -45,6 +49,8 @@ public long sizeEstimate(BufferedRecord<IndexedRecord>
record) {
return sizeOfRecord;
}
// do not contain size of Avro schema as the schema is reused among records
+ Schema recordSchema = record.getRecord().getSchema();
+ long sizeOfSchema =
sizeOfSchemaMap.computeIfAbsent(recordSchema.getFields().size(), arity ->
ObjectSizeCalculator.getObjectSize(recordSchema));
Review Comment:
cc @cshuo to review this, guess there is no much perf regression after the
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
