jonvex commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2353726715
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/convert/AvroInternalSchemaConverter.java:
##########
@@ -567,32 +587,27 @@ private static Schema
visitInternalPrimitiveToBuildAvroPrimitiveType(Type.Primit
return Schema.createFixed(name, null, null, fixed.getFixedSize());
}
- case DECIMAL: {
- Types.DecimalType decimal = (Types.DecimalType) primitive;
+ case DECIMAL:
+ case DECIMAL_FIXED: {
+ Types.DecimalTypeFixed decimal = (Types.DecimalTypeFixed) primitive;
// NOTE: All schemas corresponding to Avro's type [[FIXED]] are
generated
// with the "fixed" name to stay compatible w/
[[SchemaConverters]]
String name = recordName + AVRO_NAME_DELIMITER + "fixed";
Schema fixedSchema = Schema.createFixed(name,
- null, null, computeMinBytesForPrecision(decimal.precision()));
+ null, null, decimal.getFixedSize());
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
