lokeshj1703 commented on code in PR #13741:
URL: https://github.com/apache/hudi/pull/13741#discussion_r2348808900
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/HoodieSparkIndexClient.java:
##########
@@ -194,13 +200,13 @@ public void drop(HoodieTableMetaClient metaClient, String
indexName, boolean ign
Option<HoodieIndexDefinition> indexDefinitionOpt =
metaClient.getIndexMetadata()
.map(HoodieIndexMetadata::getIndexDefinitions)
.map(definition -> definition.get(indexName));
- try (SparkRDDWriteClient writeClient = getWriteClient(metaClient,
indexDefinitionOpt, Option.empty())) {
+ try (SparkRDDWriteClient writeClient = getWriteClient(metaClient,
indexDefinitionOpt, Option.empty(), Collections.emptyMap())) {
writeClient.dropIndex(Collections.singletonList(indexName));
}
}
private SparkRDDWriteClient getWriteClient(HoodieTableMetaClient metaClient,
Option<HoodieIndexDefinition> indexDefinitionOpt,
- Option<String> indexTypeOpt) {
+ Option<String> indexTypeOpt,
Map<String, String> overrideConfigs) {
Review Comment:
Addressed
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/HoodieSparkIndexClient.java:
##########
@@ -113,9 +115,13 @@ private void createRecordIndex(HoodieTableMetaClient
metaClient, String userInde
throw new HoodieMetadataIndexException("Index already exists: " +
userIndexName);
}
+ Map<String, String> overrideOpts = new HashMap<>();
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
