rmahindra123 commented on code in PR #13851:
URL: https://github.com/apache/hudi/pull/13851#discussion_r2334476872
##########
hudi-common/src/main/java/org/apache/hudi/metrics/prometheus/PrometheusReporter.java:
##########
@@ -101,12 +150,100 @@ public void report() {
@Override
public void stop() {
- collectorRegistry.unregister(metricExports);
- HTTPServer httpServer = PORT_TO_SERVER.remove(serverPort);
- if (httpServer != null) {
- httpServer.stop();
+ try {
Review Comment:
do the stopped check before the lock (synchronized)
and call another method static synchronized cleanup to cleanup the server
and its state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
