yihua commented on code in PR #13836:
URL: https://github.com/apache/hudi/pull/13836#discussion_r2331645165
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -172,27 +176,24 @@ private static Functions.Function3<String, String,
TypedProperties, StorageLockC
@VisibleForTesting
StorageBasedLockProvider(
- String ownerId,
- TypedProperties properties,
- Functions.Function3<String, Long, Supplier<Boolean>, HeartbeatManager>
heartbeatManagerLoader,
- Functions.Function3<String, String, TypedProperties, StorageLockClient>
storageLockClientLoader,
- Logger logger,
- HoodieLockMetrics hoodieLockMetrics) {
+ String ownerId,
+ TypedProperties properties,
+ Functions.Function3<String, Long, Supplier<Boolean>,
HeartbeatManager> heartbeatManagerLoader,
+ Functions.Function3<String, String, TypedProperties,
StorageLockClient> storageLockClientLoader,
+ Logger logger,
+ HoodieLockMetrics hoodieLockMetrics) {
Review Comment:
nit: I think the indentation should be 4 spaces. Could you check your Java
checkstyle configuration in IDE?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/audit/AuditService.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.transaction.lock.audit;
+
+import org.apache.hudi.ApiMaturityLevel;
+import org.apache.hudi.PublicAPIClass;
+
+/**
+ * Generic audit service interface for tracking operation lifecycles.
+ * Provides a single method for recording all types of audit operations.
+ */
+@PublicAPIClass(maturity = ApiMaturityLevel.EVOLVING)
+public interface AuditService extends AutoCloseable {
+
+ /**
+ * Records an audit operation with the given state and timestamp.
+ *
+ * @param state The type of operation (START, RENEW, END)
+ * @param timestamp When the operation occurred
+ * @throws Exception if the operation cannot be recorded
+ */
+ void recordOperation(AuditOperationState state, long timestamp) throws
Exception;
Review Comment:
Similar here on using `@PublicAPIMethod`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
