yihua commented on code in PR #13711: URL: https://github.com/apache/hudi/pull/13711#discussion_r2323108108
########## hudi-common/src/main/java/org/apache/hudi/avro/ValueType.java: ########## @@ -0,0 +1,637 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.avro; + +import org.apache.hudi.avro.model.ArrayWrapper; +import org.apache.hudi.common.util.DateTimeUtils; +import org.apache.hudi.common.util.collection.ArrayComparable; + +import org.apache.avro.LogicalTypes; +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericData; +import org.apache.avro.generic.GenericRecord; +import org.apache.avro.util.Utf8; +import org.apache.parquet.io.api.Binary; +import org.apache.parquet.schema.LogicalTypeTokenParser; +import org.apache.parquet.schema.PrimitiveType; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.math.MathContext; +import java.math.RoundingMode; +import java.nio.ByteBuffer; +import java.sql.Date; +import java.sql.Timestamp; +import java.time.Instant; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.time.LocalTime; +import java.time.ZoneOffset; +import java.util.Objects; +import java.util.UUID; +import java.util.function.BiFunction; +import java.util.function.Function; + +import static org.apache.hudi.avro.HoodieAvroUtils.convertBytesToBigDecimal; +import static org.apache.hudi.common.util.DateTimeUtils.instantToMicros; +import static org.apache.hudi.common.util.DateTimeUtils.instantToNanos; +import static org.apache.hudi.common.util.DateTimeUtils.microsToInstant; +import static org.apache.hudi.common.util.DateTimeUtils.nanosToInstant; +import static org.apache.hudi.common.util.StringUtils.getUTF8Bytes; + +public enum ValueType { Review Comment: cc @vinothchandar @bvaradar @balaji-varadarajan-ai For support of column stats on all primitive and logical types with comprehensiveness and consistency across engines and schema systems, this PR introduces a new `ValueType` for defining the "type" of min and max values to store inside the column stats index. Since RFC-99 is going to introduce a new type system, this enum class serves as an interim solution for Hudi 1.1 to make the type management maintainable. This class is designed to keep the migration to the new type system in mind, so that callers should just replace the existing calls with the new type system when ready to reduce migration overhead. Also this is a use case to check to make sure all same functionality are still supported by the new type system as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
