danny0405 commented on code in PR #13742:
URL: https://github.com/apache/hudi/pull/13742#discussion_r2308990683
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordMerger.java:
##########
@@ -111,17 +119,16 @@ public interface HoodieRecordMerger extends Serializable {
* ts | price | tags
* 16 | 2.8 | fruit,juicy
*
- * @param older Older record.
- * @param oldSchema Schema of the older record.
- * @param newer Newer record.
- * @param newSchema Schema of the newer record.
- * @param readerSchema Reader schema containing all the fields to read. This
is used to maintain
- * the ordering of the fields of the merged record.
- * @param props Configuration in {@link TypedProperties}.
- * @return The merged record and schema.
+ * @param older Older record.
+ * @param newer Newer record.
+ * @param readerSchema Reader schema containing all the fields to read.
This is used to maintain
+ * the ordering of the fields of the merged record.
+ * @param recordContext the record context for accessing and manipulating
the records.
+ * @param props Configuration in {@link TypedProperties}.
+ * @return The merged record and schema. The record is expected to be
non-null. If the record represents a deletion, the operation must be set as
{@link HoodieOperation#DELETE}.
* @throws IOException upon merging error.
*/
- default Option<Pair<HoodieRecord, Schema>> partialMerge(HoodieRecord older,
Schema oldSchema, HoodieRecord newer, Schema newSchema, Schema readerSchema,
TypedProperties props) throws IOException {
+ default <T> BufferedRecord<T> partialMerge(BufferedRecord<T> older,
BufferedRecord<T> newer, Schema readerSchema, RecordContext<T> recordContext,
TypedProperties props) throws IOException {
Review Comment:
we also need to fix the `fullOuterMerge` to use buffered record or just
remove it because I didn't see any uses of it in the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
