danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2308969040
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkBaseIndexSupport.scala:
##########
@@ -173,7 +174,13 @@ abstract class SparkBaseIndexSupport(spark: SparkSession,
var recordKeyQueries: List[Expression] = List.empty
var compositeRecordKeys: List[String] = List.empty
val recordKeyOpt = getRecordKeyConfig
- val isComplexRecordKey = recordKeyOpt.map(recordKeys =>
recordKeys.length).getOrElse(0) > 1
+ val isComplexRecordKey = {
+ val fieldCount = recordKeyOpt.map(recordKeys =>
recordKeys.length).getOrElse(0)
+ // Consider as complex if:
+ // 1. Multiple fields (> 1), OR
+ // 2. Using complex key generator with single record key field
+ fieldCount > 1 ||
isComplexKeyGeneratorWithSingleRecordKeyField(metaClient.getTableConfig)
Review Comment:
> we avoid using data skipping if the key encoding cannot be derived
It will yield wrong query results here, a match case would become mismatch.
or we doc it well in some places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
