sgomezvillamor commented on PR #13770: URL: https://github.com/apache/hudi/pull/13770#issuecomment-3233565253
Hi @nsivabalan This PR replaces the DataHub-provided `AvroSchemaConverter` with a custom implementation, which is my main concern. Ideally, the logic should remain within DataHub, so any issues can be addressed upstream if necessary. A few months back, I fixed some cases and used those (apparently) same test cases here: https://github.com/datahub-project/datahub/pull/12087 * Does your PR add any new test cases not already covered in DataHub repo? * Do you see specific issues with the schema fields generated by the `AvroSchemaConverter`? I have noted that Hudi is using a version from Dec 13th https://github.com/apache/hudi/blob/040719434317ad8c7a28756796efddb91579fc05/hudi-sync/hudi-datahub-sync/pom.xml#L36-L46 https://mvnrepository.com/artifact/io.acryl/datahub-client-java8/0.15.0rc20 And my PR was merged on Dec, 16th. Have you tried with a later release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
