cshuo commented on code in PR #13724:
URL: https://github.com/apache/hudi/pull/13724#discussion_r2307245673
##########
hudi-io/src/main/java/org/apache/hudi/io/hfile/HFileReaderImpl.java:
##########
@@ -311,7 +312,14 @@ private Option<BlockIndexEntry>
getNextBlockIndexEntry(BlockIndexEntry entry) {
return Option.of(keyBlockIndexEntryEntry.getValue());
}
- private HFileDataBlock instantiateHFileDataBlock(BlockIndexEntry
blockToRead) throws IOException {
+ /**
+ * Creates an HFile data block.
+ *
+ * @param blockToRead the block index entry to read
+ * @return the instantiated HFile data block
+ * @throws IOException if there's an error reading the block
+ */
+ public HFileDataBlock instantiateHFileDataBlock(BlockIndexEntry blockToRead)
throws IOException {
Review Comment:
public -> protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
