danny0405 commented on code in PR #13424:
URL: https://github.com/apache/hudi/pull/13424#discussion_r2305925681
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -178,6 +179,16 @@ private static GlueAsyncClient
buildAsyncClient(HiveSyncConfig config) {
}
}
+ @Override
+ public String getTableName() {
+ return config.getStringOrDefault(GLUE_SYNC_TABLE_NAME,
GLUE_SYNC_TABLE_NAME.getInferFunction().get().apply(config).get());
Review Comment:
Looks like we always fetch the db and table name from the sync client from
the sync tool, so I guess there is no need to infer the names again in these
getters? Just initializes them well in the sync client constructor and return
it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
