linliu-code commented on code in PR #13424:
URL: https://github.com/apache/hudi/pull/13424#discussion_r2302398476
##########
hudi-sync/hudi-datahub-sync/src/main/java/org/apache/hudi/sync/datahub/config/DataHubSyncConfig.java:
##########
@@ -115,6 +119,22 @@ public class DataHubSyncConfig extends HoodieSyncConfig {
.defaultValue(true)
.markAdvanced()
.withDocumentation("Suppress exceptions during DataHub sync. This is
true by default to ensure that when running inline with other jobs, the sync
does not fail the job.");
+ public static final ConfigProperty<String> META_SYNC_DATAHUB_DATABASE_NAME =
ConfigProperty
+ .key("hoodie.meta.sync.datahub.database.name")
+ .noDefaultValue()
+ .withInferFunction(cfg ->
Option.ofNullable(cfg.getString(META_SYNC_DATABASE_NAME.key()))
+ .or(() -> Option.of(cfg.getStringOrDefault(DATABASE_NAME,
META_SYNC_DATABASE_NAME.defaultValue()))))
Review Comment:
`META_SYNC_DATABASE_NAME.defaultValue()` or `DATABASE_NAME.defaultValue()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
