yihua commented on code in PR #13764:
URL: https://github.com/apache/hudi/pull/13764#discussion_r2301689450


##########
hudi-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java:
##########
@@ -52,6 +52,7 @@
 public class HoodieMetricsConfig extends HoodieConfig {
 
   public static final String METRIC_PREFIX = "hoodie.metrics";
+  public static final String META_SYNC_BASE_PATH_KEY = 
"hoodie.datasource.meta.sync.base.path";

Review Comment:
   `HoodieConfig` is the base class for config classes.  Ideally this variable 
should be moved to `HoodieSyncConfig` but the class is in `hudi-sync-common` 
module which is not accessible here.  So `HoodieCommonConfig` is fine for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to