rahil-c commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2290318486
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -126,12 +126,9 @@ protected RowDataKeyGen(
this.partitionPathProjection = null;
} else {
this.partitionPathProjection = getProjection(this.partitionPathFields,
fieldNames, fieldTypes);
- if (simpleRecordKey) {
- // single record key with multiple partition fields
- encodesSimpleRecordKeyWithFieldName =
isComplexKeygenEncodeSingleRecordKeyFieldName;
- }
}
if (simpleRecordKey) {
+ encodesSimpleRecordKeyWithFieldName =
isComplexKeygenEncodeSingleRecordKeyFieldName;
Review Comment:
@danny0405
Can you please share a public doc or some code pointer to where this is
enforced of single partition field is not allowed for complex key gen?
From my understandings users can technically use complex key gen with single
partition field. Unless this was the historical impl of how flink hudi
integration has always been which differs from Spark?
The issue is if you remove this change and try running the flink IT test
`ITTestSchemaEvolution`#testCompaction youll run into a failure on the encoding
not being correct for recordkey. So if you are not for this change I am trying
to understand what is the proper fix/behavior?
cc @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
