nsivabalan commented on code in PR #13721:
URL: https://github.com/apache/hudi/pull/13721#discussion_r2279746893
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/PartialUpdateHandler.java:
##########
@@ -67,21 +67,17 @@ BufferedRecord<T> partialMerge(BufferedRecord<T> newRecord,
boolean keepOldMetadataColumns) {
// Note that: When either newRecord or oldRecord is a delete record,
// skip partial update since delete records do not have
meaningful columns.
- if (partialUpdateMode == PartialUpdateMode.NONE
- || null == oldRecord
+ if (null == oldRecord
Review Comment:
nope.
the PartialUpdateMode is optional when we reach BufferedRecordMerger.
and by the time we reach `PartialUpdateHandler`, it has to be non empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
