the-other-tim-brown commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2278057054
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -492,10 +487,13 @@ private static <R> Option<HoodieRecord<R>>
mergeIncomingWithExistingRecord(
// the record was deleted
return Option.empty();
}
- String partitionPath = inferPartitionPath(incoming, existing,
writeSchemaWithMetaFields, keyGenerator, existingRecordContext, mergeResult);
+ Schema recordSchema =
incomingRecordContext.getSchemaFromBufferRecord(mergeResult);
+ String partitionPath = inferPartitionPath(incoming, existing,
recordSchema, keyGenerator, existingRecordContext, mergeResult);
HoodieRecord<R> result =
existingRecordContext.constructHoodieRecord(mergeResult, partitionPath);
+ HoodieRecord<R> withMeta = result.prependMetaFields(recordSchema,
writeSchemaWithMetaFields,
Review Comment:
I've removed this now, let's see if anything fails. I ran the RLI and
secondary index testing locally and they were passing. May have been due to
some other error at the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
