the-other-tim-brown commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2277907392
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -251,6 +344,31 @@ public List<WriteStatus> close() {
}
}
+ private Option<BaseFileUpdateCallback<T>> createCallback() {
+ List<BaseFileUpdateCallback<T>> callbacks = new ArrayList<>();
+ // Handle CDC workflow.
+ if (cdcLogger.isPresent()) {
+ callbacks.add(new CDCCallback<>(cdcLogger.get(), readerContext));
+ }
+ // Indexes are not updated during compaction
+ if (operation.isEmpty()) {
+ // record index callback
+ if (this.writeStatus.isTrackingSuccessfulWrites()) {
+ writeStatus.manuallyTrackSuccess();
+ callbacks.add(new RecordLevelIndexCallback<>(writeStatus,
newRecordLocation, partitionPath));
+ }
+ // Stream secondary index stats.
+ if (isSecondaryIndexStatsStreamingWritesEnabled) {
+ callbacks.add(new SecondaryIndexCallback<>(
Review Comment:
No, that is not what we discussed. The discussion was to avoid conversion to
HoodieRecord just to update SI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
