danny0405 commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2273653510
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -150,6 +151,7 @@ public abstract class HoodieTable<T, I, K, O> implements
Serializable {
private transient FileSystemViewManager viewManager;
protected final transient HoodieEngineContext context;
+ private final ReaderContextFactory<T> readerContextFactoryForWrite;
Review Comment:
we can remove the reader context factory in hoodie table, and instantiate a
reader context factory in `SparkUpsertCommitActionExecutor`, in
`SparkUpsertCommitActionExecutor`, override the method
`BaseSparkCommitActionExecutor#getUpdateHandle` to set up the reader context
explicitly, may also need to add a set method in
`FileGroupReaderBasedMergeHandle`, only this handle needs this currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
