the-other-tim-brown commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2268409012
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieEngineContext.java:
##########
@@ -139,15 +139,16 @@ public abstract <I, K, V> List<V> reduceByKey(
/**
* Returns reader context factory for write operations in the table.
*
- * @param metaClient Table meta client
- * @param recordType Record type
- * @param properties Typed properties
+ * @param metaClient Table meta client
+ * @param recordType Record type
+ * @param properties Typed properties
+ * @param outputsCustomPayloads Whether the reader context factory should
output custom payloads. Final merging of records before writes does not require
custom payloads.
*/
public ReaderContextFactory<?>
getReaderContextFactoryForWrite(HoodieTableMetaClient metaClient,
HoodieRecord.HoodieRecordType recordType,
-
TypedProperties properties) {
+
TypedProperties properties, boolean outputsCustomPayloads) {
Review Comment:
We'll still need it for ExpressionPayload and for any user provided payload
so it is not temporary but these restrictions may allow us to clean things up
further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
