rahil-c commented on code in PR #13687:
URL: https://github.com/apache/hudi/pull/13687#discussion_r2265105633
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngradeLegacy.java:
##########
@@ -709,10 +710,11 @@ void testNeedsUpgrade() {
assertTrue(shouldUpgrade);
// assert upgrade for table version 8 from table version 6 with auto
upgrade set to false
+ // should return false
when(writeConfig.autoUpgrade()).thenReturn(false);
shouldUpgrade = new UpgradeDowngrade(metaClient, writeConfig, context,
null)
.needsUpgrade(HoodieTableVersion.EIGHT);
- assertTrue(shouldUpgrade);
+ assertFalse(shouldUpgrade);
Review Comment:
I tried actually adding a recent test for this in the `TestMORDataSource` to
cover combination in the `needsUpgrade` let me know if these cases look good
to you.
https://github.com/apache/hudi/pull/13687/files#diff-c1ef6a426bb9c0c502b5c309fc7425d19b13ae41033b9db4b1c7ae12e108ee88R1788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
