xushiyan commented on code in PR #412:
URL: https://github.com/apache/hudi-rs/pull/412#discussion_r2264340257
##########
python/src/internal.rs:
##########
@@ -239,6 +251,48 @@ impl From<&Instant> for HudiInstant {
}
}
+#[cfg(not(tarpaulin_include))]
+#[pyclass(name = "HudiDataSource")]
+#[derive(Clone)]
+pub struct HudiDataSource {
+ table: InternalHudiDataSource,
Review Comment:
in rust, we have hudi-datafusion crate, so HudiDataSource is meant for
datafusion.
In python, we need to make the name explicit for datafusion so people don't
confuse it with datasource for other integrations (in future).
Also can we make all related functionalities in this PR available only when
the python `datafusion` feature is enabled? like people use `pip install
hudi[datafusion]` to access the related features.
##########
python/hudi/_internal.pyi:
##########
@@ -349,3 +349,18 @@ def build_hudi_table(
HudiTable: An instance of hudi table.
"""
...
+@dataclass(init=False)
+class HudiDataSource:
Review Comment:
would love to see this refactored into another `.pyi` for better code
organization. it'll be optional here and you can do it separately if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
