cshuo commented on code in PR #13696:
URL: https://github.com/apache/hudi/pull/13696#discussion_r2262704027
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcInputFormat.java:
##########
@@ -397,8 +420,8 @@ public boolean hasNext() {
this.currentImage = newRow;
return true;
} else {
- // an existed record is updated.
- HoodieRecord<RowData> historyRecord = new
HoodieFlinkRecord(existed);
+ // an existed record is updated, assuming new record and existing
record share the same hoodie key
Review Comment:
it make sense, since the `existed` is extract from `beforeImages` with
`record.getRecordKey`.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcInputFormat.java:
##########
@@ -397,8 +420,8 @@ public boolean hasNext() {
this.currentImage = newRow;
return true;
} else {
- // an existed record is updated.
- HoodieRecord<RowData> historyRecord = new
HoodieFlinkRecord(existed);
+ // an existed record is updated, assuming new record and existing
record share the same hoodie key
Review Comment:
it makes sense, since the `existed` is extract from `beforeImages` with
`record.getRecordKey`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
