xushiyan commented on code in PR #408: URL: https://github.com/apache/hudi-rs/pull/408#discussion_r2258267370
########## release/bump_version_in_main.sh: ########## @@ -109,7 +141,7 @@ echo "Created new branch: $branch_name" # Commit the changes git add . -commit_message="build(release): bump version to $new_version" +commit_message="build(release): bump version to $new_rust_version (Rust) and $new_cpp_version (C++)" Review Comment: this can be reverted, we don't distinguish rust and c++ versions. just that cmakelist.txt can't accept -dev suffix ########## release/bump_version_in_main.sh: ########## @@ -81,23 +89,47 @@ fi echo "Current version of $crate: $current_version" -# Calculate new version -new_version=$(bump_version "$current_version" "$bump_type") +# Calculate new versions +new_rust_version=$(bump_version "$current_version" "$bump_type" "true") +new_cpp_version=$(bump_version "$current_version" "$bump_type" "false") -echo "New version for $crate: $new_version" +echo "New Rust version for $crate: $new_rust_version" +echo "New C++ version: $new_cpp_version" -# Update version using cargo set-version -cargo set-version "$new_version" --manifest-path "$crate/Cargo.toml" +# Update Rust version using cargo set-version +cargo set-version "$new_rust_version" --manifest-path "$crate/Cargo.toml" Review Comment: try not to name vars to distinguish by using `rust_version` vs `cpp_version`, as they should be the same, except that in cmakelist.txt we drop the `-dev` as a special case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
