danny0405 commented on code in PR #13679:
URL: https://github.com/apache/hudi/pull/13679#discussion_r2255758195
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -289,4 +469,141 @@ private GenericRecord convertOutput(T record) {
return convertedRecord == null ? null :
readerContext.getRecordContext().convertToAvroRecord(convertedRecord,
requestedSchema.get());
}
}
+
+ private static class RecordLevelIndexCallback<T> implements
BaseFileUpdateCallback<T> {
+ private final Map<String, HoodieRecordUpdateState> recordUpdateStateMap =
new HashMap<>();
+
+ @Override
+ public void onUpdate(String recordKey, T previousRecord, T mergedRecord) {
+ this.recordUpdateStateMap.put(recordKey, HoodieRecordUpdateState.UPDATE);
Review Comment:
there is no need to use a map to keep the state, the record is handled
one-by-one, just one variable here should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]