linliu-code commented on code in PR #13642:
URL: https://github.com/apache/hudi/pull/13642#discussion_r2254745819


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -144,23 +178,18 @@ public void run(HoodieTableVersion toVersion, String 
instantTime) {
               .run(toVersion, instantTime);
         }
       } catch (Exception e) {
-        LOG.warn("Unable to upgrade or downgrade the metadata table to version 
" + toVersion
-            + ", ignoring the error and continue.", e);
+        throw new HoodieUpgradeDowngradeException("Upgrade/downgrade for the 
Hudi metadata table failed. "
+            + "Please try again. If the failure repeats for metadata table, it 
is recommended to disable "
+            + "the metadata table so that the upgrade and downgrade can 
continue for the data table.", e);

Review Comment:
   If the user disabled MDT and upgrade the data table, and then re-enable the 
MDT, is the MDT recreated or old version of MDT still persists?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to