zhangyue19921010 commented on code in PR #13409:
URL: https://github.com/apache/hudi/pull/13409#discussion_r2247431131
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -622,6 +622,27 @@ private FlinkOptions() {
.withDescription("Maximum memory in MB for a write task, when the
threshold hits,\n"
+ "it flushes the max size data bucket to avoid OOM, default 1GB");
+ @AdvancedConfig
+ public static final ConfigOption<Boolean> WRITE_BUFFER_SORT_ENABLED =
ConfigOptions
+ .key("write.sort.enabled")
+ .booleanType()
+ .defaultValue(false) // default no sort
+ .withDescription("Whether to enable buffer sort within append write
function.");
Review Comment:
I still think we need to Implement a complete sorting semantics.
We can refer to StreamWriteFunction and use Buckets to control the
implementation of flush.
Fortunately, most of the code in this PR can be reused, just need to improve
the flush control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
