linliu-code commented on code in PR #13649:
URL: https://github.com/apache/hudi/pull/13649#discussion_r2245694275
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java:
##########
@@ -187,6 +187,12 @@ protected void
bulkInsertAndCommit(BaseHoodieWriteClient<?, JavaRDD<HoodieRecord
@Override
protected void upsertAndCommit(BaseHoodieWriteClient<?,
JavaRDD<HoodieRecord>, ?, JavaRDD<WriteStatus>> writeClient, String
instantTime, JavaRDD<HoodieRecord> preppedRecordInputs) {
+ // When specified, reduce the parallelism of input record RDD to improve
write performance.
+ int parallelism =
dataWriteConfig.getMetadataConfig().getRecordPreparationParallelism();
Review Comment:
There are two write configs: dataWriteConfig, and metadataWriteConfig in
this writer. I think we should use dataWriteConfig since metadataWriteConfig is
copied from dataWriteConfig, and may not have all configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
